asyncapi / bindings

AsyncAPI bindings specifications
Apache License 2.0
72 stars 75 forks source link

Enable additionalProperties for kafka topicConfigurationObject #231

Closed gokerakc closed 8 months ago

gokerakc commented 11 months ago

Reason/Context

Currently, only 5 topic configuration properties are supported by the asyncapi kafka binding (json schema here).

These properties are;

But in some cases, there is a need to specify vendor-specific topic configurations (e.g. confluent-topic-configs). For that reason I think it makes sense to increase the version of that binding and enable additionalProperties for the topicConfigurationObject.

In my use case, I need to use the following additional properties and they can also be added to the topicConfigurationObject if you see a good fit. Please see the properties from the vendor and proposed property names for the topicConfigurationObject:

Please share your thoughts about enabling additional properties and adding these optional properties to the object.

github-actions[bot] commented 11 months ago

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

gokerakc commented 11 months ago

@lbroudoux I would like to get your thoughts on this because you commented about adding new properties before.

derberg commented 8 months ago

looks like completed