search

asyncapi / bindings

AsyncAPI bindings specifications
Apache License 2.0
71 stars 75 forks source link

SNS section not compatible with AsyncAPI 3.0.0 #255

Open mateusz-wlosek-ppro opened 3 months ago

mateusz-wlosek-ppro commented 3 months ago

SNS README is not compatible with AsyncAPI 3.0.0 E.g. the section mentions subscribe which is not supported anymore

https://github.com/asyncapi/bindings/blob/master/sns/README.md https://www.asyncapi.com/blog/release-notes-3.0.0

github-actions[bot] commented 3 months ago

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

derberg commented 1 month ago

@dpwdec @iancooper please take a look

jturek-olx commented 1 month ago

SQS README has the same issue. Any news on that?

iancooper commented 1 month ago

@jturek-olx @derberg Thanks for pinging me. I'll talk to @dpwdec

dpwdec commented 1 month ago

@jturek-olx @derberg I'll draft a new version that uses AsyncAPI V3. However, as we know that V2 is stilled being used widely I think we should keep the V2 bindings available on master. So should we disambiguate them in same way the main project does with a 2.x.x folder and a 3.0.0 folder?

dpwdec commented 1 month ago

I've raised a PR for SNS: https://github.com/asyncapi/bindings/pull/260/files

iancooper commented 1 month ago

I have merged the PR. @jturek-olx @derberg if you still have concerns please comment here and we can look at a fix