Closed akshatnema closed 1 year ago
This PR doesn't introduce a one property rename to simply align it's name with the existing schema like PR #109. Phrase
If your code generator generates Python code, then specify Python, even if code
generator itself is written in JavaScript.
raised several questions:
{
"language": {
"type": "array",
"items": {
"type": "string"
}
}
}
?
.asyncapi-tool
at all?@derberg @magicmatatjahu
(due to holiday season, answers might delay up to after ~Jan 10, 2023)
If your code generator generates Python code, then specify Python, even if code generator itself is written in JavaScript.
@aeworxet The language
parameter inside .asyncapi-tool
file doesn't specify the code generated by the generator. Rather, it specifies the primary language with which the generator has been made. And it was decided before that we will have a single primary language for each tool, which is majorly being used to build the tool. Hence, it is a string, not an array.
Even if there was a decision made, but change was forgotten to be introduced into the schema, the https://github.com/asyncapi/website/blob/master/scripts/tools/tools-schema.json currently still reads in the description of the language
property
If your code generator generates Python code, then specify Python, even if code
generator itself is written in JavaScript.
so I have to hit the brakes on this PR until senior engineers come to any agreement.
@akshatnema @aeworxet language
refers to the language that you can use in the "runtime". That is, for generators it should be the language that the generator generates, but bundler even though it operates on YAML and JSON it does not mean that these are the target language, it's JS/TS because in this language it's written. It's a information if you can use given lib/script/api in your codebase :)
Should the description https://github.com/asyncapi/website/blob/master/scripts/tools/tools-schema.json be altered then? Made more clear maybe?
/rtm
:tada: This PR is included in version 0.3.10 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
@akshatnema Next time please use chore:
Description The .asyncapi-tool file is corrected according to the errors made while validating with the schema.