search

asyncapi / bundler

Combine multiple AsyncAPI specification files into one.
Apache License 2.0
29 stars 15 forks source link

fix: remove obsolete `try...catch` #176

Closed tsauerwein closed 4 months ago

tsauerwein commented 4 months ago

Description

Issue https://github.com/asyncapi/cli/issues/1475 gives an example where an invalid external reference is ignored, and all other documents are skipped. Instead of silently failing, this PR proposes to let the error propagate.

Related issue(s) Fixes https://github.com/asyncapi/cli/issues/1475

aeworxet commented 4 months ago

I do not normally do try...catches only for the sake of error-swallowing, so I surely did it for some reason, but I honestly do not remember for what exactly.

Either that use case has already been taken care of, or I will see the same edge case and process it in another way.

@souvikns, this PR looks good to me, but can you please do this simple review only so I'm not reviewing my own code? Also, should the title be fix: remove obsolete try...catch ?

aeworxet commented 4 months ago

/rtm

asyncapi-bot commented 4 months ago

:tada: This PR is included in version 0.5.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket: