search

asyncapi / bundler

Combine multiple AsyncAPI specification files into one.
Apache License 2.0
30 stars 16 forks source link

chore: use typescript type for declaring options #180

Closed Laupetin closed 1 week ago

Laupetin commented 2 months ago

Currently the options object of the bundler is just declared as any, despite using typescript.

Adding a type for it improves autocompletion when trying to use the bundler as a library in another project and generally improves type recognition in the code.

Souvikns commented 3 weeks ago

You have some conflicts @Laupetin, feel free to resolve them and I will start with reviewing.

aeworxet commented 3 weeks ago

This matter is addressed in https://github.com/asyncapi/bundler/pull/188.

Laupetin commented 3 weeks ago

Hey thanks, i wont be able to adjust the PR for another week unfortunately. If you want to address it in another PR, feel free to do it there and close this one :)