asyncapi / cli

CLI to work with your AsyncAPI files. You can validate them and in the future use a generator and even bootstrap a new file. Contributions are welcomed!
https://www.asyncapi.com/tools/cli
Apache License 2.0
188 stars 164 forks source link

fix: update package `@asyncapi/bundler` to version `0.6.1` #1492

Closed aeworxet closed 3 months ago

aeworxet commented 3 months ago

This PR updates the @asyncapi/bundler package to version 0.6.0.

Shurtu-gal commented 3 months ago

@aeworxet the tests are currently not passing.

aeworxet commented 3 months ago

Bundler v0.6.0 uses structuredClone(), which was added only in Node 17.

Should it be stated in CLI's documentation that the minimal version of Node.js is v18 or is it too early to make users upgrade to v18 and I should rewrite Bundler's functionality with a polyfill or without structuredClone() at all (good ol' JSON.parse(JSON.stringify())) (downgrade?)

Souvikns commented 3 months ago

Well according to the website v20 is the current LTS version, but still v16 is still wildly used so I think we should still support v16 for some time in the near future.

aeworxet commented 3 months ago

Replaced in Bundler native structuredClone() with a polyfill to keep compatibility with Node.js v16.

I will update this PR as soon as https://github.com/asyncapi/bundler/pull/183 is merged and Bundler v0.6.1 is released.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

aeworxet commented 3 months ago

/rtm

asyncapi-bot commented 3 months ago

:tada: This PR is included in version 2.3.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: