asyncapi / conference-website

Website for the AsyncAPI online conference
https://conference.asyncapi.com
25 stars 100 forks source link

fix: speakers images #400

Closed Aryan4884 closed 1 month ago

Aryan4884 commented 1 month ago

396

This PR resolves that issue by downloading and storing the speaker images locally. This change ensures that the speaker images are always available, thereby improving the overall reliability and consistency of the website.

Changes Made: Speaker Images Storage: Downloaded all speaker images from external URLs and stored them in the /public/img/speakers/ directory. Updated the speaker image paths to reference the local files instead of external URLs. Speaker Component: Updated the image src in the Speaker component to use the new local paths. Benefits: Reliability: The images are no longer dependent on external URLs, preventing broken image issues caused by changes in external sources. Performance: Local images reduce latency and improve load time, since they are served directly from our server. Maintenance: Easier management of speaker images, as they are all stored and versioned within the project. Screenshot 2024-10-01 175046

netlify[bot] commented 1 month ago

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
Latest commit 5dbc1e2344ae4cd46d80ae62d5192c9f5f053623
Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/6718bd8f70d4330008abb5d1
Deploy Preview https://deploy-preview-400--peaceful-ramanujan-288045.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Aryan4884 commented 1 month ago

Please ignore multiple commit as I have forgotten to make a different branch for this separate issue, thatswhy my previous commit which was for different issue are also getting shown.

ashmit-coder commented 1 month ago

Hey @Aryan4884 please follow the pr naming conventions as mentioned by the asyncapi-bot above.

Aryan4884 commented 1 month ago

Is it ok now?

Aryan4884 commented 1 month ago

@AceTheCreator changed the format to .webp

ashmit-coder commented 1 month ago

@Aryan4884 there is some error, please resolve it. In my opinion its arising from the conference-website submodule in your PR.

Aryan4884 commented 1 month ago

@ashmit-coder By mistake i messed up the file directories and submodules. But now its fine.

ashmit-coder commented 1 month ago

@Aryan4884 please resolve the merge conflicts.

Aryan4884 commented 1 month ago

@ashmit-coder done

AceTheCreator commented 1 month ago

@Aryan4884, kindly resolve the conflict in this PR. we should be good to go once that's fixed 👍🏾

Aryan4884 commented 1 month ago

@AceTheCreator done

ashmit-coder commented 1 month ago

LGTM! @AceTheCreator

AceTheCreator commented 1 month ago

/rtm