asyncapi / conference-website

Website for the AsyncAPI online conference
https://conference.asyncapi.com
25 stars 100 forks source link

fix: content aligned in mobile view #407

Closed Aryan4884 closed 3 weeks ago

Aryan4884 commented 1 month ago

345

This PR addresses the issue of text alignment within the Dropdown component. Previously, the text was left-aligned on smaller screens, which affected the overall user experience.

Changes Made: Previously:

{active}
{/ Center the button text /} After Change:
{active}
{/ Center the button text /}

Previously: Screenshot 2024-10-03 114349 After change: Screenshot 2024-10-03 114506

netlify[bot] commented 1 month ago

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
Latest commit 7512d855fe4bd7c562d109601a8c1bf21a64a7b0
Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/671759335e88190008207b39
Deploy Preview https://deploy-preview-407--peaceful-ramanujan-288045.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ashmit-coder commented 1 month ago

Hey @Aryan4884 could you please include the screenshots of the changes that you have made.

Aryan4884 commented 1 month ago

@ashmit-coder uploaded the screenshots

ashmit-coder commented 1 month ago

Hey @Mayaleeeee What do you think about this design change?

Aryan4884 commented 1 month ago

@AceTheCreator Yes, it works perfectly fine.But the aligned text in the mobile view just looks better somehow.

ashmit-coder commented 1 month ago

@Aryan4884 i honestly don't see a reason for this enhancement cuz it works perfectly and the only suggested improvement is the arrow rotation and color, don't you think? 🤷🏽‍♂️

So are we moving ahead with these changes?

AceTheCreator commented 1 month ago

@AceTheCreator Yes, it works perfectly fine.But the aligned text in the mobile view just looks better somehow.

Hmm... I beg to differ

@Mayaleeeee your thoughts?

AceTheCreator commented 3 weeks ago

@Aryan4884 i'm closing this PR :/