search

asyncapi / conference-website

Website for the AsyncAPI online conference
https://conference.asyncapi.com
25 stars 100 forks source link

fix: ticket section render issue #445

Open toffee-k21 opened 3 weeks ago

toffee-k21 commented 3 weeks ago

Description

netlify[bot] commented 3 weeks ago

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
Latest commit 86f13f2875d73d95be693d3ad43b711dd85f58fe
Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/6737138f696151000895ec65
Deploy Preview https://deploy-preview-445--peaceful-ramanujan-288045.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

toffee-k21 commented 3 weeks ago

@toffee-k21 we should stick to using the existing ticket cards. We should list all the tickets and only enable the upcoming conference ticket(which should come first)

Hey @AceTheCreator, I've updated the Ticket section to show upcoming events first, followed by events ended. This functionality was already implemented

AceTheCreator commented 2 weeks ago

@toffee-k21 we should stick to using the existing ticket cards. We should list all the tickets and only enable the upcoming conference ticket(which should come first)

Hey @AceTheCreator, I've updated the Ticket section to show upcoming events first, followed by events ended. This functionality was already implemented

But i think cards shouldn't have background

toffee-k21 commented 2 weeks ago

But i think cards shouldn't have background

Hey @AceTheCreator , I have removed the background as you mentioned

ashmit-coder commented 2 weeks ago

But i think cards shouldn't have background

Hey @AceTheCreator , I have removed the background as you mentioned

Looks great @toffee-k21 . But don't you think the items in the second row shoud start from the middle? (The london UK ticket card) cc: @AceTheCreator

toffee-k21 commented 2 weeks ago

Looks great @toffee-k21 . But don't you think the items in the second row shoud start from the middle? (The london UK ticket card) cc: @AceTheCreator

@AceTheCreator, I have fixed the alignment and made the cards align in the middle

toffee-k21 commented 2 weeks ago

@toffee-k21 i think it'll look visually appealing if the list of tickets is rendered in a carousel layout. wyt?

Great idea! Displaying tickets in this way will keep the layout compact, conserving vertical space and this will also improve readability