asyncapi / conference-website

Website for the AsyncAPI online conference
https://conference.asyncapi.com
25 stars 100 forks source link

feat: updates hamburger menu and navbar #458

Closed Tanuj1718 closed 1 week ago

Tanuj1718 commented 1 week ago

Description

https://github.com/user-attachments/assets/22e1e3a4-bd38-4b1e-856a-3672b9e0b030

Related issue(s)

Fixes #455

netlify[bot] commented 1 week ago

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
Latest commit 4e9ca50701f421100fc1bced6dbb82c8f2d5059f
Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/673204fc9a8fc60008fa34f4
Deploy Preview https://deploy-preview-458--peaceful-ramanujan-288045.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

thulieblack commented 1 week ago

Do we need this change @AceTheCreator @ashmit-coder

ashmit-coder commented 1 week ago

Hey @Tanuj1718 the black colour of the navbar looks quiet unpleasing. I think the issue was just to make the hamburger icon sticky to provide better mobility for mobile users.

Tanuj1718 commented 1 week ago

@ashmit-coder Oh my bad! Should I make it sticky for all devices because everytime user has to scroll to the top for accessing navigation options or the feature should be only for mobile devices?

AceTheCreator commented 1 week ago

@Tanuj1718, sorry i'd have to close this PR as someone is already working on a fix that's currently been reviewed

Tanuj1718 commented 1 week ago

@Tanuj1718, sorry i'd have to close this PR as someone is already working on a fix that's currently been reviewed

Oh ! No problem, will try to contribute in other ways.