asyncapi / conference-website

Website for the AsyncAPI online conference
https://conference.asyncapi.com
25 stars 100 forks source link

feat: sticky hamburger menu for mobile version #460

Open r3yc0n1c opened 1 week ago

r3yc0n1c commented 1 week ago

Description

Related issue(s) Resolves #455

Demo Animation

netlify[bot] commented 1 week ago

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
Latest commit 7e49dd8fbb9abf4474882c88daaf6c5c6250dad5
Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/673c711521799e0008c600c3
Deploy Preview https://deploy-preview-460--peaceful-ramanujan-288045.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

thulieblack commented 1 week ago

Someone else is working on this PR #458

r3yc0n1c commented 1 week ago

Someone else is working on this PR #458

I was working on this before them... ref: here

thulieblack commented 1 week ago

sorry my bad please continue

catosaurusrex2003 commented 1 week ago

Instead of making the navbar transparent, could we consider using a blur effect so that the content scrolling behind the navbar is not visible?

ashmit-coder commented 1 week ago

Instead of making the navbar transparent, could we consider using a blur effect so that the content scrolling behind the navbar is not visible?

@Mayaleeeee would have to approve this.

ashmit-coder commented 1 week ago

Instead of making the navbar transparent, could we consider using a blur effect so that the content scrolling behind the navbar is not visible?

that would sure look better @r3yc0n1c , thanks for the suggestion @catosaurusrex2003

r3yc0n1c commented 1 week ago

Instead of making the navbar transparent, could we consider using a blur effect so that the content scrolling behind the navbar is not visible?

that would sure look better @r3yc0n1c , thanks for the suggestion @catosaurusrex2003

sure! working on in... will send a PR soon

r3yc0n1c commented 1 week ago

update:

Screenshot 2024-11-12 203816 Screenshot 2024-11-12 203834 Screenshot 2024-11-12 204044

catosaurusrex2003 commented 1 week ago

image the navbar blur is looking good 🚀

Should we also convert the solid purple color of hamburger dropdown to a translucent blur just like the navbar?

like taking inspiration of navbar dropdown in mobile viewport from here https://datahack.djss4ds.in/ Pay attention to how the background of the dropdown is translucent and blurred and center alligned.

@Mayaleeeee @ashmit-coder

AceTheCreator commented 1 week ago

@r3yc0n1c do you plan on adding the suggested changes by @catosaurusrex2003 in the comment above?

r3yc0n1c commented 6 days ago

@r3yc0n1c do you plan on adding the suggested changes by @catosaurusrex2003 in the comment above?

yeah sure! it looks good actually... shall I get started with the blurred menu items?

Mayaleeeee commented 3 days ago

image the navbar blur is looking good 🚀

Should we also convert the solid purple color of hamburger dropdown to a translucent blur just like the navbar?

like taking inspiration of navbar dropdown in mobile viewport from here https://datahack.djss4ds.in/ Pay attention to how the background of the dropdown is translucent and blurred and center alligned.

@Mayaleeeee @ashmit-coder

What solid purple colour?

r3yc0n1c commented 2 days ago

image the navbar blur is looking good 🚀 Should we also convert the solid purple color of hamburger dropdown to a translucent blur just like the navbar? like taking inspiration of navbar dropdown in mobile viewport from here https://datahack.djss4ds.in/ Pay attention to how the background of the dropdown is translucent and blurred and center alligned. @Mayaleeeee @ashmit-coder

What solid purple colour?

I think he's referring to the dark purple background (#1B1130) we use in the navbar:

image

catosaurusrex2003 commented 2 days ago

I think he's referring to the dark purple background (#1B1130) we use in the navbar:

yes, i am referring to that.

Its just a suggestion

@r3yc0n1c you can give it a try. @Mayaleeeee once it's done, we can choose the one that looks better.

r3yc0n1c commented 2 days ago

I think he's referring to the dark purple background (#1B1130) we use in the navbar:

yes, i am referring to that.

Its just a suggestion

@r3yc0n1c you can give it a try.

@Mayaleeeee once it's done, we can choose the one that looks better.

sure! WIP