asyncapi / conference-website

Website for the AsyncAPI online conference
https://conference.asyncapi.com
25 stars 100 forks source link

fix: redirection Link fix #467

Open TenzDelek opened 1 week ago

TenzDelek commented 1 week ago

Description fixed the youtube redirection link Related issue(s)

Fixes #466

netlify[bot] commented 1 week ago

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
Latest commit 926f3c15c799db42cc0ea73fbb4ce5fe1428849a
Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/673c9b214a5f150008c65734
Deploy Preview https://deploy-preview-467--peaceful-ramanujan-288045.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

TenzDelek commented 1 week ago

@TenzDelek, i noticed were the link is been referenced is not a button but a text, which can easily be missed. since the text is a link, then i believed it should be underlined. wyt @ashmit-coder?

agree on that, currently, the underline is kept on hover. should I go on with the changes to add a underline?

ashmit-coder commented 1 week ago

@TenzDelek, i noticed were the link is been referenced is not a button but a text, which can easily be missed. since the text is a link, then i believed it should be underlined. wyt @ashmit-coder?

I dont think so @AceTheCreator , the underline seems to not go well with the design of the card, hence I dont think we should add it. The hover effect looks better and the text points towards it being a link.

thulieblack commented 1 week ago

Please link the text to the YouTube playlist https://youtube.com/playlist?list=PLbi1gRlP7pijItMBmw9SeeyWxuEa3jLR2&si=MNNU0r-aCmuWFPLI

TenzDelek commented 1 week ago

Please link the text to the YouTube playlist https://youtube.com/playlist?list=PLbi1gRlP7pijItMBmw9SeeyWxuEa3jLR2&si=MNNU0r-aCmuWFPLI

done

AceTheCreator commented 1 week ago

@TenzDelek, i noticed were the link is been referenced is not a button but a text, which can easily be missed. since the text is a link, then i believed it should be underlined. wyt @ashmit-coder?

I dont think so @AceTheCreator , the underline seems to not go well with the design of the card, hence I dont think we should add it. The hover effect looks better and the text points towards it being a link.

Hmm... I actually missed that it was a link. Why not make it a button if adding an underline is gonna mess with the UI.

wyt @Mayaleeeee?

Mayaleeeee commented 3 days ago

@TenzDelek, i noticed were the link is been referenced is not a button but a text, which can easily be missed. since the text is a link, then i believed it should be underlined. wyt @ashmit-coder?

I dont think so @AceTheCreator , the underline seems to not go well with the design of the card, hence I dont think we should add it. The hover effect looks better and the text points towards it being a link.

Hmm... I actually missed that it was a link. Why not make it a button if adding an underline is gonna mess with the UI.

wyt @Mayaleeeee?

Thanks for the ping @AceTheCreator

Could you please provide a screenshot of where I can find the issue on the website? @TenzDelek

TenzDelek commented 3 days ago
image

https://conference.asyncapi.com/venue/Online

cc @Mayaleeeee

TenzDelek commented 2 days ago
image

have underlined the link as maya suggested. imo only underlining the text would be best. as it is an external link a button doesn't sound right . @Mayaleeeee cc @AceTheCreator @ashmit-coder