fix: resolved lint warnings - Githubissues

asyncapi / conference-website

Website for the AsyncAPI online conference

https://conference.asyncapi.com

25 stars 100 forks source link

fix: resolved lint warnings #468

Open SahilDahekar opened 1 week ago

SahilDahekar commented 1 week ago

Description

Fixed lint warning in stepThree.js & select.js files.

Related issue(s)

Fixes #328

netlify[bot] commented 1 week ago

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name	Link
Latest commit	4df52c1024363f8b3604644fc9d3adb514dcff94
Latest deploy log	https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/67344a9453ddbb0008a2ed3a
Deploy Preview	https://deploy-preview-468--peaceful-ramanujan-288045.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

SahilDahekar commented 1 week ago

Hey @AceTheCreator , here are before and after images :-

Before :

After :

AceTheCreator commented 1 week ago

@ashmit-coder your review is needed :)

ashmit-coder commented 1 week ago

@ashmit-coder your review is needed :)

Hey @AceTheCreator waiting for this pr https://github.com/asyncapi/conference-website/pull/386

So that the tests are ran on this pr, just to be sure all functionalities are working.

SahilDahekar commented 7 hours ago

Hey @ashmit-coder , since PR #386 is merged can we proceed with this PR.

ashmit-coder commented 5 hours ago

Hey @ashmit-coder , since PR #386 is merged can we proceed with this PR.

Sure! Soon