search

asyncapi / diff

Diff is a library that compares two AsyncAPI Documents and provides information about the differences by pointing out explicitly information like breaking changes.
Apache License 2.0
27 stars 12 forks source link

chore: update @asyncapi/parser to 2.1.0 #151

Closed aayushmau5 closed 1 year ago

aayushmau5 commented 1 year ago

Description

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

aayushmau5 commented 1 year ago

https://github.com/asyncapi/diff/actions/runs/5108591475/jobs/9182547896?pr=151#step:10:13

The job fails with this error. Not sure what's the problem? Is there any dependency missing?

cc @derberg

aayushmau5 commented 1 year ago

@jonaslagoni can you help with this? I don't think its because of #152, since all the workflows are managed by asyncapi/.github repo.

jonaslagoni commented 1 year ago

@aayushmau5 it's because you use an old version of node/npm (v14 I think) in v16 and above this problem with ajv not being found has been fixed.

But if you are upgrading node + https://github.com/asyncapi/diff/issues/152 I would go straight to v18 🙂

aayushmau5 commented 1 year ago

image locally, i'm getting the same error. Node v18.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

aayushmau5 commented 1 year ago

/rtm