asyncapi / diff

Diff is a library that compares two AsyncAPI Documents and provides information about the differences by pointing out explicitly information like breaking changes.
Apache License 2.0
27 stars 12 forks source link

AsyncAPI spec v3 support in Diff #154

Open jonaslagoni opened 1 year ago

jonaslagoni commented 1 year ago

Reason/Context

This Issue is used to track changes needed to support AsyncAPI v3. As a code owner, please edit this list of TODO tasks in order to properly track the progress 🙂 Once this issue is closed it means that v3 is now fully supported in this library.

Remaining tasks:

github-actions[bot] commented 1 year ago

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

jonaslagoni commented 1 year ago

cc codeowners @aayushmau5 @vinitshahdeo @onbit-uchenik @magicmatatjahu @derberg

Would be really cool to have this library work out the gate when we release v3, are any of you interested in scheduling a public call specifically to discuss how to enable this?

If you have any questions about how it can be achieved or v3-specific stuff I can help answer those in the meeting to enable you to progress with this 🙂

Let me know if it has any interest.

aayushmau5 commented 1 year ago

@jonaslagoni I'll start working on this.

Would be really cool to have this library work out the gate when we release v3, are any of you interested in scheduling a public call specifically to discuss how to enable this?

Sure! I haven't particularly kept up with the new spec changes, so it would be cool to get on a call and discuss the changes that needs to be made to this library.

jonaslagoni commented 1 year ago

Cool!

@aayushmau5 just let me know a date and time that fits for you and I can schedule a meeting 🙂

github-actions[bot] commented 11 months ago

This issue has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

aeworxet commented 2 months ago

Bounty Issue's service comment

Text labels: bounty/2024-Q4, bounty/advanced, bounty/coding First assignment to regular contributors: 2024-09-20 00:00:00 UTC+12:00 End Of Life after: 2024-10-31 23:59:59 UTC-12:00

@asyncapi/bounty_team

The Bounty Program is not a Mentorship Program. The accepted level of Bounty Program Participants is Middle/Senior.
Regular contributors should explain in meaningful words how they are going to approach the resolution process when expressing a desire to work on this Bounty Issue.
chinma-yyy commented 2 months ago

Hi @jonaslagoni @aeworxet, I’d like to work on this issue under the bounty program. I’ll put together a detailed approach within the next day or two and share it here.

aayushmau5 commented 2 months ago

@chinma-yyy i think it's best i work on this issue here. I already had some approach and some implementation done before this issue got stale. Will need to rework those so clubbed all the issues and will fix them on one go.

aeworxet commented 2 months ago

@aayushmau5 is an AsyncAPI Maintainer specified in https://raw.githubusercontent.com/asyncapi/community/master/MAINTAINERS.yaml, so they fall under the first category in the prioritization list.

aeworxet commented 2 months ago

Bounty Issue's Timeline

Complexity Level Assignment Date (by GitHub) Start Date (by BP Rules) End Date (by BP Rules) Draft PR Submission Final PR Merge Start Final PR Merge End
Advanced 2024-09-17 2024-10-07 2024-12-01 2024-10-27 2024-11-17 2024-12-01
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.
Keep in mind the responsibility for violations of the Timeline.
imabp commented 1 month ago

@aeworxet @aayushmau5 @jonaslagoni is this open...i would. like to work on this?

aayushmau5 commented 1 month ago

@imabp I'm working on this issue :)

imabp commented 1 month ago

Okay thanks for letting me know.. @aayushmau5 As I saw the draft PR submission is 27th Oct 2024, I thought, you are not having bandwidth for this.

cc: @aeworxet

aayushmau5 commented 1 month ago

@imabp Yeah, i had some work already done which got stale. I reopened it just now but yeah, i'm actively working on this issue.

imabp commented 1 month ago

do you need any help? @aayushmau5

aayushmau5 commented 1 month ago

@imabp not yet. I'll let you know once I get these changes done. Maybe you can pick up other issues for diff if you want to :)

imabp commented 1 month ago

Sure taking a look at them @aayushmau5 . I was developing Myer's Diff Algorithm, so had a chat with Souvik, he suggested me about this project. Thanks 🙏

aeworxet commented 3 weeks ago

@aayushmau5 (githubID 54525741), please provide an update to the PR.

aayushmau5 commented 3 weeks ago

@aeworxet I'm done with adding support for asyncapi v3. I'm in the process of writing tests for the changes.

aeworxet commented 2 weeks ago

@aayushmau5 (githubID 54525741), please provide an update to the PR.

aeworxet commented 1 week ago

@aayushmau5 (githubID 54525741), please provide an update to the PR.

aeworxet commented 1 week ago

@aayushmau5 (githubID 54525741), please provide an update to the PR.

aayushmau5 commented 1 week ago

@aeworxet I'm currently going through AsyncAPI spec v3 and adding the proper standard file for it.

aeworxet commented 4 days ago

@aayushmau5, are you on track to complete this Bounty Issue by 2024-12-01, or will you need an extension?

aayushmau5 commented 1 day ago

I will be done with standard changes for diff. Will need an extension for updating diff for CLI

aeworxet commented 16 hours ago

Upon request of the AsyncAPI Maintainer, who is responsible for the resolution of the Bounty Issue from the AsyncAPI's side and is also the Bounty Program Participant (@aayushmau5 (githubID 54525741)), all remaining target dates of the Bounty Issue's Timeline are extended by two calendar weeks.

Bounty Issue's Timeline Extended

Complexity Level Assignment Date (by GitHub) Start Date (by BP Rules) End Date (by BP Rules) Draft PR Submission Final PR Merge Start Final PR Merge End
Advanced 2024-09-17 2024-10-07 2024-12-15 2024-11-10 2024-12-01 2024-12-15
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.
Keep in mind the responsibility for violations of the Timeline.