Improve arborist (npm installation) to have no hacks

asyncapi / generator

Use your AsyncAPI definition to generate literally anything. Markdown documentation, Node.js code, HTML documentation, anything!

https://asyncapi.com/docs/tools/generator

Apache License 2.0

771 stars 233 forks source link

Improve arborist (npm installation) to have no hacks #1102

Open derberg opened 10 months ago

derberg commented 10 months ago

use this PR as inspiration, except for:

no changes to workflows
arborist version should not be changed by this issue
supported engines should not be changed by this issue

What you need to do:

just ad pacote dependency
cleanup mocks and add new one - like in linked PR
modify generator.js as it is done in linked PR

derberg commented 10 months ago

/gfi js

AayushSaini101 commented 10 months ago

I am on it

derberg commented 10 months ago

@AayushSaini101 thanks

github-actions[bot] commented 6 months ago

This issue has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

Gmin2 commented 3 months ago

As @akkshitgupta does not want to work in it anymore, i am going to take this over from the work left from #1115

derberg commented 3 months ago

@Gmin2 awesome, I closed the other PR

@akkshitgupta thanks for initial contribution!

ShashwatPS commented 1 month ago

Hey @derberg would like to work on this issue just wanted to clear one thing there's no dependency section in package.json so where should I mention the pacote dependency ?

DhairyaMajmudar commented 1 month ago

Hey @derberg would like to work on this issue just wanted to clear one thing there's no dependency section in package.json so where should I mention the pacote dependency ?

@ShashwatPS the structure of the codebase is changed a bit (Now its following monorepo architecture) you can add mentioned dependency in generator app package.json file.

derberg commented 1 month ago

as @DhairyaMajmudar wrote, add dependency to apps/generator

TheMarvelFan commented 2 weeks ago

@derberg

Is anyone working on this issue?

rajRishi22 commented 2 weeks ago

Hi @derberg , I want to work on this issue , can you please assign me this issue or should i directly raise a PR ?

Edit : I have fixed the issue , i have also updated index.md which is related to another issue in this repo can i solve both issues in the same PR?

Gmin2 commented 2 weeks ago

make seperate pr for seperate issues, and we dont generally assign issues, feel free to send a PR fixing the issue !

cc @rajRishi22 @TheMarvelFan