feat: include default nunjucks filters and new release to the generator

ayushnau commented 4 months ago

Changes Added.

Added the new Release with changesets.

Related issue(s)

ayushnau commented 4 months ago

@derberg I have added the changes for Changesets. I have used the changelog in the ci @changesets/changelog-git (didnt make it false in the config) cause there is ongoing bug in the changesets which they have not given the solution yet. And this is basically causing changesets still search for the CHANGELOG.md inspite of making it false in the config. here is the link https://github.com/changesets/action/issues/256

Also I was needed to install the @changesets/cli in the ci also cause once I run the chagnesets/cli command directly with npx in ci it is installing the cli version and correctly working fine, but then the same ci flow changelog is not getting detected causing the error.

derberg commented 4 months ago

@ayushnau

Regarding your comment about @changesets/cli that can be used with npx, but changelong-git must be installed. Please adda proper comment to YAML file, with link to an issue, so we overtime can followup and improve - otherwise this knowledge will get out of our heads in few months.
why are there changes to package-lock
please add a section in readme, that explain how releasing works now. What has to be done to release minor/patch/major
please explain what will happen once we merge this PR. Btw did you test it somewhere already? can you show results?
please explore how to make it happen, that new filters package is also in dependencies of generator. How to make it happen that once we merge a PR that is marked as "filter", it is automatically bumped in generator

ayushnau commented 4 months ago

@derberg

Added the comment regarding it.
The Changes in package.lockare expected as the generator-filters is also added. Turborepo will add the required dependency together in package.lock for both the packgaes. Also I have updated the jest version to 27.3.1 without it some test were getting broke. I was getting Error node:events not found. found the solution here https://github.com/Azure/azure-sdk-for-js/issues/29014
Added the section in the readmd.md.
I thing the repo will be published to respective npm directories will add the test results.
In 5th point you mean. how to bump the version of generator when there is changes in the generator-filter is that right? If that is the question than it is possible.
Also in beginning you told me to setup the filter in such a way that it is not required to add them to package.json and the filters should get loaded by itself. I checked this one. and found this straightforward. we just need to set the filter object in generator this.templateParams = {filter: "@asyncapi/generator-filters"}; and update other places if the template params is set to {}.
Also we dont want to push the generator-filters as a seprate package like you said before the in the issue??