asyncapi / generator

Use your AsyncAPI definition to generate literally anything. Markdown documentation, Node.js code, HTML documentation, anything!
https://asyncapi.com/docs/tools/generator
Apache License 2.0
767 stars 232 forks source link

refactor: use an object spread instead of `Object.assign` in filters #1276

Closed rishabhr4 closed 1 month ago

rishabhr4 commented 1 month ago

Description refactored apps/nunjucks-filters/src/index.js mentioned in this issue

Changes Made Removed object assign and used object spread

related https://github.com/asyncapi/generator/issues/1272

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 69c6068838a449fa4967b6a21cf280dee3e70cdc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

derberg commented 1 month ago

@Gmin2 thanks for helping with review

derberg commented 1 month ago

tests are failing, linter - to be more precise

rishabhr4 commented 1 month ago

tests are failing, linter - to be more precise

sorry i have now ran the tests and fixed it

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

derberg commented 1 month ago

/rtm