search

asyncapi / generator

Use your AsyncAPI definition to generate literally anything. Markdown documentation, Node.js code, HTML documentation, anything!
https://asyncapi.com/docs/tools/generator
Apache License 2.0
767 stars 232 forks source link

perf: optimize dockerfile #1281

Closed thebedigupta closed 1 month ago

thebedigupta commented 1 month ago

Description In this PR I worked on this issues

Attaching updated test results file after the changes which I made test-results.txt

  1. Remove cache after installing packages or store it in a cache mount
  2. Merge this RUN instruction with the consecutive ones
  3. Surround this variable with double quotes; otherwise, it can lead to unexpected behavior
  4. Include the ARG instruction in the build stage where it is used

Results

I solved this issue after reading sonarcloud suggestion and how it work

Related issue(s)

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: acecefc16314c15d0518e96dc9c6627a8c9c83a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

thebedigupta commented 1 month ago

please remove cli.js changes

done

DhairyaMajmudar commented 1 month ago

Pls. have a look on the comment https://github.com/asyncapi/generator/pull/1283#issuecomment-2404066707 to fix this