asyncapi / generator

Use your AsyncAPI definition to generate literally anything. Markdown documentation, Node.js code, HTML documentation, anything!
https://asyncapi.com/docs/tools/generator
Apache License 2.0
767 stars 232 forks source link

fix: simplify variable initialization #1283

Closed thebedigupta closed 1 month ago

thebedigupta commented 1 month ago

Description

In this PR I try to solve this issue

I am also attching test files captured results test-results.txt

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 2ec4151b191c010d8a43c42f5987b9f7c8457cad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

thebedigupta commented 1 month ago

remove changes to cli.js and as usual make sure you do not use any autoformatter

done

thebedigupta commented 1 month ago

cli.js is still showing up in the list of modified files

let me create another PR for this issue

DhairyaMajmudar commented 1 month ago

let me create another PR for this issue

@thebedigupta no need to open a separate PR, by mistake, you've pushed the empty cli.js file since the content in the file is removed that's why it's showing in the list of modified files. To fix this you can follow the following steps:

-> Copy and paste the content of the original cli.js file to your empty file. -> Commit and push the changes to your PR

thebedigupta commented 1 month ago

let me create another PR for this issue

@thebedigupta no need to open a separate PR, by mistake, you've pushed the empty cli.js file since the content in the file is removed that's why it's showing in the list of modified files. To fix this you can follow the following steps:

-> Copy and paste the content of the original cli.js file to your empty file. -> Commit and push the changes to your PR

Oh it's that much easy ok I will do it and thank you for your suggestion

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

thebedigupta commented 1 month ago

let me create another PR for this issue

@thebedigupta no need to open a separate PR, by mistake, you've pushed the empty cli.js file since the content in the file is removed that's why it's showing in the list of modified files. To fix this you can follow the following steps: -> Copy and paste the content of the original cli.js file to your empty file. -> Commit and push the changes to your PR

Oh it's that much easy ok I will do it and thank you for your suggestion

I tried it but it was not working i don't know why anyway let me create another PR for removing these cli.js file issues