asyncapi / generator

Use your AsyncAPI definition to generate literally anything. Markdown documentation, Node.js code, HTML documentation, anything!
https://asyncapi.com/docs/tools/generator
Apache License 2.0
767 stars 232 forks source link

fix: overall structure and reliability of the function #1288

Closed thebedigupta closed 1 month ago

thebedigupta commented 1 month ago

Description In this PR I worked on that issue This is the test results that I performed test-results.txt

Resolve

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: cda6448038ba421dbbe02df08b410419ff178d6f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

thebedigupta commented 1 month ago

why there are so many changes in this file, can you please explain?

why function is now sync? wasn't it enough to just remove async from promise?

sorry for overcomplicating the work you are right removing async is the straight-forward approach

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud