asyncapi / generator

Use your AsyncAPI definition to generate literally anything. Markdown documentation, Node.js code, HTML documentation, anything!
https://asyncapi.com/docs/tools/generator
Apache License 2.0
767 stars 232 forks source link

perf: optimize dockerfile #1298

Open thebedigupta opened 1 month ago

thebedigupta commented 1 month ago

Description

Updated Test Results test-results.md

Problems that I worked in this PR

  1. Remove cache after installing packages
  2. Merge this run instruction with the consecutive ones
  3. Surround this variable with double quotes; otherwise, it can lead to unexpected behavior
  4. Include the ARG instruction in the build stage where it is used

I solved this issue after reading sonarcloud suggestion and how it work

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 0420a0419b59af5314be12c2bb3884f19ad7a1fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

thebedigupta commented 1 month ago

once you react to all comments, please also run build of the docker image locally + use the docker to verify all works as expected

I am updating test results file Please review it and then just tell me if I did something wrong

derberg commented 3 weeks ago

I see in test result that you did run docker build but haven't seen docker run.

use the docker to verify all works as expected

I mean't - please try to use the image you build locally, to check if generation still works

going with this should do the trick

thebedigupta commented 3 weeks ago

I see in test result that you did run docker build but haven't seen docker run.

use the docker to verify all works as expected

I mean't - please try to use the image you build locally, to check if generation still works

going with this should do the trick

@derberg I was trying to understand where things goes wrong Give me some time if you have any suggestions on how to run image then please let me know docker

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

derberg commented 3 weeks ago

but the command that is under the link I provided, isn't it working?

thebedigupta commented 3 weeks ago

but the command that is under the link I provided, isn't it working?

Update the test results Please check again

derberg commented 2 weeks ago

@thebedigupta you mean in description? I don't see info in test result that docker run was called