Closed Shurtu-gal closed 7 months ago
I will take out the config approach and keep it simple. Same with cli_version too.
@derberg README is also updated
@asyncapi/bounty_team
I have added the test workflow. @derberg Sample workflow can be found here
@derberg The requested changes have been added. Regarding sonarcloud hotspot, I had made the changes to fix it but it led to permission issues when making docker container for GitHub action as can be seen in the run here
@Shurtu-gal please bring back the user settings in dockerfile and simply silent sonar by adding https://github.com/asyncapi/cli/blob/master/.sonarcloud.properties file to this repo, just adjust it to ignore dockerfile, and add comment why we ignore it: that this docker file is for starting containers that should run only in GitHub Actions and no other environments, and running with security violation is ok
Done @derberg.
Kudos, no new issues were introduced!
0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
works well on my side
because we know there is one potential breaking change in case of parameters
field, and that -p
needs to be used, I added !
to the title so we release this new version as new major
/rtm
@allcontributors please add @Shurtu-gal for code,test,doc,ideas,maintainance
@derberg
I've put up a pull request to add @Shurtu-gal! :tada:
Description
The PR changes the GitHub action from being just a generator to an all-in-one tool.
What's New:
Changes Made
Breaking Changes:
Previously, the parameter option was exclusive to template parameters. It has now been expanded to apply to all commands. Therefore, users must now add -p before template params for the same functionality.
Things left
Related issue(s) Fixes #281