search

asyncapi / github-action-for-cli

GitHub Action with generator, validator, converter and others - all in one for your AsyncAPI documents with AsyncAPI CLI as backbone
Apache License 2.0
49 stars 19 forks source link

[BUG] AsyncAPI v3 support #401

Closed PedroQwe closed 2 months ago

PedroQwe commented 3 months ago

Describe the bug.

I am trying to use the asyncapi/github-action-for-cli to generate models from a file using AsyncAPI v3 and I am getting this error: Error: Generate Models command does not support AsyncAPI v3 yet, please checkout https://github.com/asyncapi/modelina/issues/1376

However, the issue 1376 has already been fixed and asyncapi cli already supports v3.

Expected behavior

The models should be generated given that asyncapi cli already supports v3.

Screenshots

image

How to Reproduce

  1. Create a AsyncAPI specification file following v3
  2. Create a github action to generate models from the file created in step 1.

🥦 Browser

Google Chrome

👀 Have you checked for similar open issues?

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

None

github-actions[bot] commented 3 months ago

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

pioneer2k commented 2 months ago

@PedroQwe is there a reason why do you use such an old version of the markdown-template? I think v3 support was coming with the release 1.4.0 of that template. Maybe that is the problem? We are using the generator with the latest html-template and eveything is working fine with v3 spec files.

Shurtu-gal commented 2 months ago

@PedroQwe the problem lies in the version of CLI.

You have two options:

[!NOTE] FYI: we are working on tying CLI and GitHub action versioning for better experience, so you wouldn't have to face these problems.

Shurtu-gal commented 2 months ago

Please let me know if this works and I will move forward with closing this ticket.