search

asyncapi / glee

Glee — The AsyncAPI framework that will make you smile again :)
87 stars 61 forks source link

Update Kafka Adapter to support spec v3 #673

Open oviecodes opened 8 months ago

oviecodes commented 8 months ago

Describe the bug

We need to update the kafka adapter to support v3 of the spec. Currently, from what I noticed, the parsed methods seem to be different from v2 and it causes the adapter to fail.

How to Reproduce

Update the spec to v3 and run the project in the examples/kafka-test directory. First, you'll get an error related to the reply.channel(I'll have to check more, I'm slightly confused by the reply feature). However, we can get past that by adding a conditional to check for reply. Finally once the reply.channel error out of the way, you'll get the following error

TypeError: Cannot read properties of undefined (reading 'type') at file:///Users/a/Documents/asyncapi/glee/dist/adapters/kafka/index.js:29:87 at Array.find (<anonymous>) at KafkaAdapter.<anonymous> (file:///Users/a/Documents/asyncapi/glee/dist/adapters/kafka/index.js:29:69) at Generator.next (<anonymous>) at fulfilled (file:///Users/a/Documents/asyncapi/glee/dist/adapters/kafka/index.js:4:58)

Expected behavior

The Kafka adapter should start correctly without errors.

@Souvikns @KhudaDad414 I'll start working on a fix as this is blocking #411.

github-actions[bot] commented 4 months ago

This issue has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

KhudaDad414 commented 4 months ago

Still relevant.

github-actions[bot] commented 3 days ago

This issue has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart: