asyncapi / jasyncapi

/jay-sync-api/ is a Java code-first tool for AsyncAPI specification
Apache License 2.0
67 stars 23 forks source link

[BUG] AsyncAPI v3.0.0 no longer serializable #198

Closed ChMThiel closed 4 months ago

ChMThiel commented 4 months ago

Describe the bug.

Im trying to upgrade the AsyncApi Quarkus-Plugin to AsyncAPI v3.

In V2 of com.asyncapi.v2._0_0.model.AsyncAPI, the field asysncapi was not final: grafik in V3 it's final (com.asyncapi.v3._0_0.model.AsyncAPI): grafik This prevents the object to be serialized/deserialized in my Quarkus-Extension:

Caused by: java.lang.RuntimeException: java.lang.RuntimeException: Cannot serialise field 'asyncapi' on object 
AsyncAPI(asyncapi=3.0.0,
...
 as the property is read only

Expected behavior

AsyncAPI in V3 is de/serializable to by Quarkus' ByteRecorder

Screenshots

see above

How to Reproduce

see https://github.com/quarkiverse/quarkus-asyncapi/tree/asyncApi_v3

🥦 Browser

Mozilla Firefox

👀 Have you checked for similar open issues?

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

No, someone else can work on it

github-actions[bot] commented 4 months ago

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Pakisan commented 4 months ago

@ChMThiel Hi!

Will change it today. Please, switch to /release/1.0.0-RC2

This release will introduce breaking changes:

ChMThiel commented 4 months ago

@Pakisan Thank you very much for the quick reply! Are there any plans when the release 1.0.0 will be available?

Pakisan commented 4 months ago

@Pakisan Thank you very much for the quick reply!

Are there any plans when the release 1.0.0 will be available?

I'm not sure when exactly I'll release 1.0.0

I want to add new bindings versions and left it for a while(few months I think), to

  1. Collect feedback from users
  2. Add v3 support to apicurio
  3. Add my tests to our json schemas and TCK repos
Pakisan commented 4 months ago

@ChMThiel I removed final from AsyncAPI.asyncapi field

ChMThiel commented 4 months ago

@ChMThiel I removed final from AsyncAPI.asyncapi field

@Pakisan will you release a 1.0.0-RC2 so i can access the changes, please?

Pakisan commented 4 months ago

@ChMThiel I removed final from AsyncAPI.asyncapi field

@Pakisan will you release a 1.0.0-RC2 so i can access the changes, please?

Check updated release branch. If everything is working as expected, I'll publish it May 16/17(waiting for response from other folks)

ChMThiel commented 4 months ago

@ChMThiel I removed final from AsyncAPI.asyncapi field

@Pakisan will you release a 1.0.0-RC2 so i can access the changes, please?

Check updated release branch. If everything is working as expected, I'll publish it May 16/17(waiting for response from other folks)

@Pakisan @fjtirado I checked the current 1.0.0-RC2 localy. Everything works, all i had to do is to adjust some imports... looking forward to the release...

Pakisan commented 4 months ago

@ChMThiel I removed final from AsyncAPI.asyncapi field

@Pakisan will you release a 1.0.0-RC2 so i can access the changes, please?

Check updated release branch. If everything is working as expected, I'll publish it May 16/17(waiting for response from other folks)

@Pakisan @fjtirado I checked the current 1.0.0-RC2 localy. Everything works, all i had to do is to adjust some imports... looking forward to the release...

Done