Support decimal min and max

asyncapi / java-spring-template

Java Spring template for the AsyncAPI Generator

Apache License 2.0

66 stars 53 forks source link

Support decimal min and max #326

Open Tenischev opened 1 year ago

Tenischev commented 1 year ago

Describe the bug

I defined a field as type number and format double with minimum as 0.01. The asyncapi cli generator generated with java springboot template defined the field correctly as Double but the jakarta validation @Min accepts only long. It seems like only @DecimalMin can support decimal types but it requires a string type.

Bug reported by Sajeesh Kumar in Slack

Expected behavior

DecimalMin \ DecimalMax is used for Double validation

codingmickey commented 1 year ago

Hi @Tenischev I would like to help resolve this!

Tenischev commented 1 year ago

Hi @codingmickey! Glad to hear =) Please go ahead and make PR. From my brief look update is required only in template/src/main/java/com/asyncapi/model/$$objectSchema$$.java file where @Min and @Max annotations are set.

Tenischev commented 11 months ago

Hey @codingmickey any progress with it? Do you need a help?

rakeshkodathala commented 6 months ago

Hi, @Tenischev, Could you please check my PR and let me know if any changes are required?

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart: