search

asyncapi / java-spring-template

Java Spring template for the AsyncAPI Generator
Apache License 2.0
66 stars 54 forks source link

MqttConfig.java does not handle both a subscribe and publish under the same topic #414

Open gaby-roland opened 3 months ago

gaby-roland commented 3 months ago

Having a publish and subscribe channels under the same topic is allowed, however, it results in compilation errors due to the subscribe topic variables not being created. This is because the loop iterates through the channels, and uses if/elif to create the publish/subscribe topic variables. If both publish and subscribe are defined in the yaml, only the publish variables are created in the Config.java class. This is an easy fix, just change the if/elif to if/if to handle this edge case.

https://github.com/asyncapi/java-spring-template/blob/a1ae80524074d02a855ef173aa6e10f4baa6b725/partials/MqttConfig.java#L73

github-actions[bot] commented 3 months ago

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Tenischev commented 3 months ago

Hello @gaby-roland Thank you for the report! Could you please also provide an example of AsyncAPI file with this configuration? If possible, could you please explain application logic that you expect from application that read and write to the same topic?