search

asyncapi / java-template

Java template for the AsyncAPI Generator
Apache License 2.0
10 stars 12 forks source link

feat: add api version to v3 #168

Closed AayushSaini101 closed 7 months ago

AayushSaini101 commented 8 months ago

Resolve: #118

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

derberg commented 7 months ago

@AayushSaini101 did you test this change? I mean after just changing the version, did you try to run code generation with such change? I would be surprised if that is enough to make template support v3

dalelane commented 7 months ago

I think more is needed than this. I've tried to make a start in moving this forward in https://github.com/asyncapi/java-template/pull/186 but I still don't think the work is complete even with that.

dalelane commented 7 months ago

closing in favour of https://github.com/asyncapi/java-template/pull/186