asyncapi / java-template

Java template for the AsyncAPI Generator
Apache License 2.0
14 stars 13 forks source link

fix: populate env.json with valid Kafka bootstrap addresses #188

Closed dalelane closed 8 months ago

dalelane commented 8 months ago

The generator was putting the "kafka-secure://" protocol prefix in the bootstrap address for generated Kafka apps, which the Kafka client library rejects as an invalid URL.

This commit uses the hostname if it is available (v3 docs) but falls back to using the url otherwise (v2 docs).

dalelane commented 8 months ago

/rtm

asyncapi-bot commented 8 months ago

Hello, @dalelane! 👋🏼 This PR is not up to date with the base branch and can't be merged. Please update your branch manually with the latest version of the base branch. PRO-TIP: Add a comment to your PR with the text: /au or /autoupdate and our bot will take care of updating the branch in the future. The only requirement for this to work is to enable Allow edits from maintainers option in your PR. Thanks 😄

dalelane commented 8 months ago

/rtm /au

asyncapi-bot commented 8 months ago

Hello, @dalelane! 👋🏼 This PR is not up to date with the base branch and can't be merged. Please update your branch manually with the latest version of the base branch. PRO-TIP: Add a comment to your PR with the text: /au or /autoupdate and our bot will take care of updating the branch in the future. The only requirement for this to work is to enable Allow edits from maintainers option in your PR. Thanks 😄

sonarcloud[bot] commented 8 months ago

Please retry analysis of this Pull-Request directly on SonarCloud

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.8% Duplication on New Code

See analysis details on SonarCloud

dalelane commented 8 months ago

/rtm

asyncapi-bot commented 8 months ago

:tada: This PR is included in version 0.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: