search

asyncapi / nodejs-template

This template generates a server using your AsyncAPI document. It supports multiple different protocols, like Kafka or MQTT. It is designed in the way that generated code is a library and with it's API you can start the server, send messages or register a middleware for listening incoming messages. Runtime message validation included.
40 stars 29 forks source link

AsyncAPI spec v3 support in Node.js template #215

Closed jonaslagoni closed 6 months ago

jonaslagoni commented 1 year ago

Reason/Context

This Issue is used to track changes needed to support AsyncAPI v3. As a code owner, please edit this list of TODO tasks in order to properly track the progress 🙂 Once this issue is closed it means that v3 is now fully supported in this library.

Remaining tasks:

github-actions[bot] commented 1 year ago

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

lukas-mertens commented 9 months ago

@derberg Any progress on this? I would like to start using AsyncAPI and it feels like it would be best to start with the new spec version right away, but it feels like most of the code generators are not compatible yet. Or is it still recommended to go with v2 of the spec?

derberg commented 6 months ago

v3 release done, and coincidence is that it also support asyncapi v3 https://github.com/asyncapi/nodejs-template/releases/tag/v3.0.0

anyway, if there are any issues, feel free to report them

meteatamel commented 6 months ago

Is v3 supported in nodejs-template? I get this error when I try:

 asyncapi generate fromTemplate email-service-3.0.yaml @asyncapi/nodejs-template -o email-service-3.0 -p server=test

┌  AsyncAPI Generator
Error: @asyncapi/nodejs-template template does not support AsyncAPI v3 documents, please checkout https://github.com/asyncapi/nodejs-template/issues/215
derberg commented 6 months ago

@meteatamel thanks! opened PR to CLI -> https://github.com/asyncapi/cli/pull/1412

derberg commented 6 months ago

@meteatamel the latest AsyncAPI CLI release fixes the problem

meteatamel commented 6 months ago

Thanks @derberg, I tested and the code generation for Node.js works now with 3. 0

derberg commented 6 months ago

Great!!! Thanks for confirmation!

fyi @kaushik-rishi