search

asyncapi / parser-js

AsyncAPI parser for Javascript (browser-compatible too).
115 stars 91 forks source link

fix: parser will throw an error when address is null/no param but param is present #1011

Open ibishal opened 1 month ago

ibishal commented 1 month ago

Description

Now when there is parameter but the address not contain any, then it will throw an error

Related issue(s) Fixes #875

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

smoya commented 1 month ago

@ibishal the Spectral rule should apply for AsyncAPI spec v3. Not necessary for v2 (unless no cost of adding)

smoya commented 1 month ago

FYI @ibishal, this PR is part of https://github.com/asyncapi/parser-js/issues/1019 and by that, part of this Bounty Program issue. If you want to participate in the Bounty Program and get a reward ($), please express your interest in https://github.com/asyncapi/parser-js/issues/1016 and include an outline of the work you will do for each of the rules that should be added.

ibishal commented 1 month ago

FYI @ibishal, this PR is part of #1019 and by that, part of this Bounty Program issue.

i had created this PR solving the issue #875 (it is overlapping with issue #1019 ), should i close this ?

If you want to participate in the Bounty Program and get a reward ($), please express your interest in #1016 and include an outline of the work you will do for each of the rules that should be added.

i have sent a basic outline in slack(dms), should i put it in the issue too(more briefly outlining each rules) cc @smoya

smoya commented 1 month ago

i have created this PR solving the issue #875 (it is overlapping with issue #1019 )

One is a bug, the other is the issue that mentions to work on such a bugfix as part of the bounty program.

i had created this PR solving the issue #875 (it is overlapping with issue #1019 ), should i close this ?

You should follow standard procedures. Express your desire of working on such an issue, say how would you do with each of the tasks that are part of the bounty issue and not only with one. I will choose the right person based on that info.

smoya commented 4 weeks ago

Are you gonna include the rule for v3?

ibishal commented 4 weeks ago

@smoya should I ?,see the comment made by @aeworxet in the bounty issue

smoya commented 4 weeks ago

@smoya should I ?,see the comment made by @aeworxet in the bounty issue

Of course, you can work in any of the issues you want, that doesn't mean it is assigned to you. We only assign issues in programs such as Bounty, GSoC, etc.

Meaning other people is also free to work in the same one and send a PR in parallel.

ibishal commented 4 weeks ago

@smoya this PR is ready for review