search

asyncapi / parser-js

AsyncAPI parser for Javascript (browser-compatible too).
Apache License 2.0
118 stars 93 forks source link

Reenable Sonarcloud check in PR's #1033

Open smoya opened 3 months ago

smoya commented 3 months ago

As you can check here, I had to manually remove the Sonarcloud check for master branch. It seems there is some random issue. More info and possible next steps here: https://github.com/asyncapi/.github/issues/306

smoya commented 3 months ago

Reenabled.

It seems all i needed to do is to remove the required check from master branch in GH branch protection rules. Then Sonarcloud added automatically a new check into the PR's (seems like different, this one has a logo of Sonarcloud?). Then, adding back the check in branch protection like in the following screenshot (notice that the source now says Sonarcloud, where previously said "any source").

Google Chrome_8ApoACGU@2x