asyncapi / parser-js

AsyncAPI parser for Javascript (browser-compatible too).
Apache License 2.0
119 stars 97 forks source link

chore(deps): bump ajv to 8.17.1 #1042

Closed aeworxet closed 3 months ago

aeworxet commented 3 months ago

This PR upgrades ajv to version 8.17.1 to lay the foundation for fixing https://github.com/asyncapi/parser-js/issues/980.

Related to https://github.com/asyncapi/parser-js/issues/1012

aeworxet commented 3 months ago

@asyncapi/bounty_team

smoya commented 3 months ago

@aeworxet If we want to release this, you will need to include a changesets file under .changeset dir. Check the following message from changeset-bot.

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 7968a56519fc07c6c1a1420d2ca8a65c560a7934

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------- | ----- | | @asyncapi/parser | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

aeworxet commented 3 months ago
$ npx changeset
npm ERR! could not determine executable to run

$ npm install npx -g --force
npm WARN using --force Recommended protections disabled.
npm WARN deprecated npx@10.2.2: This package is now part of the npm CLI.

added 1 package in 3s

1 package is looking for funding
  run `npm fund` for details

$ npx changeset
npm ERR! cb.apply is not a function

🤷🏻

@ayushnau ?

ayushnau commented 3 months ago

the command for the cli to create changeset is this npx -p @changesets/cli changeset @aeworxet

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

aeworxet commented 3 months ago

Should command npx -p @changesets/cli changeset be written in a README somewhere? I wouldn't know it if @ayushnau didn't tell.

$ grep -iHr changesets/cli .
./node_modules/eslint-plugin-prettier/package.json:    "@changesets/cli": "^2.27.1",
./.github/workflows/release-with-changesets.yml:          version: npx -p @changesets/cli changeset version
./.github/workflows/release-with-changesets.yml:          publish: npx -p @changesets/cli changeset publish
smoya commented 3 months ago

Click here if you're a maintainer who wants to add another changeset to this PR

Sure, feel free to add it. cc @ayushnau BTW, you have a link in https://github.com/asyncapi/parser-js/pull/1042#issuecomment-2250005327 that redirects you to create the file.

aeworxet commented 3 months ago

https://github.com/asyncapi/parser-js/pull/1042#issuecomment-2250005327 redirects to

Run npx changeset or yarn changeset

while @ayushnau pointed to

npx -p @changesets/cli changeset

That's why I thought this matter needed clarification. :shrug:

Anyway, I've already added the changeset because I need to specify a new version of @asyncapi/parser in PR for both Studios; can this PR be merged?

smoya commented 3 months ago

https://github.com/asyncapi/parser-js/pull/1042#issuecomment-2250005327 redirects to

Run npx changeset or yarn changeset

while @ayushnau pointed to

npx -p @changesets/cli changeset

That's why I thought this matter needed clarification. :shrug:

Anyway, I've already added the changeset because I need to specify a new version of @asyncapi/parser in PR for both Studios; can this PR be merged?

The last link of such comment redirects you right directly to the changeset file creation: https://github.com/aeworxet/asyncapi-parser-js/new/chore-deps-bump-ajv-to-8.17.1?filename=.changeset/mean-mice-buy.md&value=---%0A%22%40asyncapi%2Fparser%22%3A%20patch%0A---%0A%0Achore(deps)%3A%20bump%20ajv%20to%208.17.1%0A Next time you can use it.

smoya commented 3 months ago

/rtm