search

asyncapi / parser-js

AsyncAPI parser for Javascript (browser-compatible too).
Apache License 2.0
119 stars 97 forks source link

fix: use JSON Pointer last element as ID for reply.channel and reply.messages[] #895

Closed smoya closed 5 months ago

smoya commented 12 months ago

Description

Fixes https://github.com/asyncapi/parser-js/issues/873

This PR puts on practice one of the solutions we might opt in for getting Id's on referenced objects via the last element of their JSON Pointer. In this case, we are doing this for the reply.channel and reply.messages[], since in the Operation Reply those are referenced via a JSON Pointer.

I'm also fixing a bug where reply.messages were expected to be a map instead of an array.

Related issue(s) Fixes https://github.com/asyncapi/parser-js/issues/873

sonarcloud[bot] commented 11 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

github-actions[bot] commented 7 months ago

This pull request has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart: