search

asyncapi / parser-js

AsyncAPI parser for Javascript (browser-compatible too).
Apache License 2.0
116 stars 92 forks source link

Add new Spectral rule to check for null addresses in channels associated with operations defining reply #916

Closed Gmin2 closed 3 months ago

Gmin2 commented 9 months ago

Fixes #875

asyncapi-bot commented 9 months ago

We require all PRs to follow Conventional Commits specification. More details 👇🏼

 No release type found in pull request title "Add new Spectral rule to check for null addresses in channels associated with operations defining reply". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit
sonarcloud[bot] commented 9 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

smoya commented 9 months ago

Hi @Min2who,

I'm confused with this PR. The issue says we miss a rule about channel parameters not being present in the channel address. Nothing related with operations.

Additionally, the code you created as Spectral rule is invalid since it doesn't follow the RulesetFunction interface.

Is there any context I'm missing?

Gmin2 commented 9 months ago

@smoya I guess i have understand the issue wrongly can you give me a brief idea of how can i test this issue locally

github-actions[bot] commented 5 months ago

This pull request has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

smoya commented 3 months ago

Please reopen if applies