asyncapi / saunter

Saunter is a code-first AsyncAPI documentation generator for dotnet.
https://www.asyncapi.com/
MIT License
204 stars 57 forks source link

"examples"field is not an Array of Maps #11

Closed meunierfrederic closed 4 years ago

meunierfrederic commented 4 years ago

In reference documentation, one can see that Message.examples field is a [Map[string,any]].

However, in Message Class, Examples member is a IDictionary<string,object>. Generated documentation validation fails (online editor here).

With the following in Message.cs line 42

        [JsonProperty("examples")]
        public IList<IDictionary<string, object>> Examples { get; set; } = new List<IDictionary<string, object>>();

generated documents are valid.

m-wild commented 4 years ago

Fixed by #12

meunierfrederic commented 4 years ago

Thanks Michael. Will you publish this fix in Saunter NuGet Package ?

On Mon, May 4, 2020 at 1:45 PM Michael Wildman notifications@github.com wrote:

Fixed by #12 https://github.com/tehmantra/saunter/pull/12

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tehmantra/saunter/issues/11#issuecomment-623415635, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHX3B66TPRV6MJW6D55YRX3RP2TFRANCNFSM4MX25WYA .

m-wild commented 4 years ago

Yep. Published in NuGet 0.1.0-alpha-42 https://www.nuget.org/packages/Saunter/0.1.0-alpha-42

meunierfrederic commented 4 years ago

Test was successful with NuGet 0.1.0-alpha-42 and 0.1.0-alpha-44. Thanks Michael