search

asyncapi / saunter

Saunter is a code-first AsyncAPI documentation generator for dotnet.
https://www.asyncapi.com/
MIT License
194 stars 55 forks source link

#173: Deprecating endpoint mapping in favor of plain middleware #174

Open ch-ti8m-michalpenka opened 10 months ago

ch-ti8m-michalpenka commented 10 months ago

see #173

m-wild commented 4 months ago

@VisualBean @yurvon-screamo are either of you familiar with aspnetcore? I haven't kept up to date with the recent changes to endpoints vs middleware.

VisualBean commented 4 months ago

@VisualBean @yurvon-screamo are either of you familiar with aspnetcore? I haven't kept up to date with the recent changes to endpoints vs middleware.

Middleware structure looks fine. My only comments on this is around caching of values. I'll take a deeper look Monday though.

This could definitely also use some integration test. If we don't have the we application factory thing yet, we can get that added to the to-do

yurvon-screamo commented 4 months ago

I disagree with internal sealed middleware.

Overloading or single usage are real scenarios.

thompson-tomo commented 2 months ago

I agree with @VisualBean that the project would benefit from caching but let's track that via: https://github.com/asyncapi/saunter/issues/198