search

asyncapi / saunter

Saunter is a code-first AsyncAPI documentation generator for dotnet.
https://www.asyncapi.com/
MIT License
194 stars 55 forks source link

Made AsyncApiSchemaOptions inherit from JsonSchemaGeneratorSettings #206

Closed Simkortet closed 1 month ago

Simkortet commented 2 months ago

Recent change to NewtonsoftJsonSchemaGeneratorSettings does not allow compatibility with System.Text.Json and forces users of the saunter library to introduce newtonsoft into their projects.

@m-wild

Simkortet commented 2 months ago

@m-wild @VisualBean @yurvon-screamo

Any chance of closing this PR?

VisualBean commented 2 months ago

@m-wild @VisualBean @yurvon-screamo

Any chance of closing this PR?

First off, it doesn't compile. Also looking at the commentary from the PR that introduced the change in the first place, it looks like it needs a bigger redesign than simply changing the basetype here.

That and there seems to be quite a few whitespace changes here as well.

Even if it compiled, you'd still have the newtonsoft dependency stemming from the SerializerSettings (without looking at the rest of the changes that introduced this dependency)