asyncapi / server-api

Server API providing official AsyncAPI tools
Apache License 2.0
31 stars 33 forks source link

feat: add deployment solution to digital ocean app platform #430

Closed Shurtu-gal closed 10 months ago

Shurtu-gal commented 10 months ago

Description

Proof that it works

Things to be noted by the maintainer

Note: this is a single-time process.

Related issue(s) Fixes #317

Shurtu-gal commented 10 months ago

@derberg A small review of GitHub workflow would be appreciated.

smoya commented 10 months ago

Comment moved to https://github.com/asyncapi/server-api/issues/317#issuecomment-1886993658

Shurtu-gal commented 10 months ago

@smoya @derberg The PR has been updated.

Successful workflow run :- https://github.com/ash17290/server-api/actions/runs/7525186615/job/20481139953 Deployed Link :- https://server-api-ek54f.ondigitalocean.app/v1/help/validate

asyncapi-bot commented 10 months ago

Hello, @Shurtu-gal! 👋🏼

    I'm 🧞🧞🧞 Genie 🧞🧞🧞 from the magic lamp. Looks like somebody needs a hand!

    At the moment the following comments are supported in pull requests:

    - `/ready-to-merge` or `/rtm` - This comment will trigger automerge of PR in case all required checks are green, approvals in place and do-not-merge label is not added
    - `/do-not-merge` or `/dnm` - This comment will block automerging even if all conditions are met and ready-to-merge label is added
    - `/autoupdate` or `/au` - This comment will add `autoupdate` label to the PR and keeps your PR up-to-date to the target branch's future changes. Unless there is a merge conflict or it is a draft PR.
smoya commented 10 months ago

Digital Ocean Application has been depoyed successfully using the terraform file @Shurtu-gal created. @fmvilas added the proper CNAME record into api.asyncapi.com to server-api-84f2u.ondigitalocean.app, which is the internal Digital Ocean domain for server-api app.

All seems working properly, the transition from K8s to App Platform happened smoothly. BTW, we do not have K8s on Digital Ocean anymore 🎉 cc @derberg

Now I'm gonna proceed configuring the env vars for the GH action to work.

smoya commented 10 months ago

Now I'm gonna proceed configuring the env vars for the GH action to work.

Ok, this is embarrassing but I have no powers for setting secrets for the CI. Would you @derberg @fmvilas help me? Thanks!

smoya commented 10 months ago

@Shurtu-gal Do you believe you could update the docs of this repo mentioning how the deploy of the infra works, and how deploys of the app work as well? Can be done in a different PR, not affecting in this case to the Bounty's timeline unless you want to do it here.

Shurtu-gal commented 10 months ago

Sure, I can do it here itself.

Shurtu-gal commented 10 months ago

@smoya done the readme update.

sonarcloud[bot] commented 10 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

smoya commented 10 months ago

DO TOKEN secret added. Time to merge and test with a new release.

Awesome work @Shurtu-gal !!!

smoya commented 10 months ago

/rtm

smoya commented 10 months ago

@all-contributors please add @Shurtu-gal for doc, infra

allcontributors[bot] commented 10 months ago

@smoya

I've put up a pull request to add @Shurtu-gal! :tada:

aeworxet commented 10 months ago

@asyncapi/bounty_team