search

asyncapi / server-api

Server API providing official AsyncAPI tools
Apache License 2.0
30 stars 33 forks source link

feat: enable push to NPM registry #452

Closed smoya closed 9 months ago

smoya commented 9 months ago

Description

We never published our NPM package to NPM registry. As it is the first time we do, we need to specify that the package (scoped package) is public, otherwise it will be considered as restricted and our push command in CI will fail, as in here.

More info: https://docs.npmjs.com/creating-and-publishing-scoped-public-packages#publishing-scoped-public-packages

We have several ways of doing this, we could just publish manually our first version to NPM, but that's not pretty cool since we would need to ask someone with the credentials (NPM TOKEN) to do. Instead, we can just add this .npmrc file with the right config to tell NPM this is a public scoped package. Alternatively, we could add a config for semantic-release, but I believe this should be in the .npmrc since it is purely related to NPM.

sonarcloud[bot] commented 9 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

smoya commented 9 months ago

@BOLT04 @magicmatatjahu Unblocking CI ASAP requires me to bypass the PR protection requirements so I can merge without your +1. If you believe this should not be here, please open a PR with the revert.

asyncapi-bot commented 9 months ago

:tada: This PR is included in version 0.16.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: