search

asyncapi / shape-up-process

This repo contains pitches and the current cycle bets. More info about the Shape Up process: https://basecamp.com/shapeup
https://shapeup.asyncapi.io
11 stars 8 forks source link

feat: trigger AsyncAPI site deploy #109

Closed smoya closed 3 years ago

smoya commented 3 years ago

Description

This PR adds a new step in the deploy.yml workflow so AsyncAPI website gets also deployed, updating the roadmap if needed.

Note that $NETLIFY_SITE_ID env var has been renamed to $NETLIFY_SHAPEUP_SITE_ID, and $NETLIFY_ASYNCAPI_SITE_ID has been added. Changes on secrets should be applied cc @derberg

netlify[bot] commented 3 years ago

:construction_worker: Deploy request for asyncapi-shape-up pending review. Visit the deploys page to approve it

:hammer: Explore the source changes: fc27691a2d67b61b74138e0502ce2fa755ac15c0

smoya commented 3 years ago

Do wee need two steps? I think that two curls in one step is enough :)

Well they perform different actions so I would always advocate for having two separate curls, as they can give you a different response. One could work, the other fail so you only need to re-run the one that failed.

derberg commented 3 years ago

secrets added

One could work, the other fail so you only need to re-run the one that failed.

you can rerun jobs but not steps afaik, so if you want to have such functionality then in the workflow file you need to have 2 independent jobs

anyway, separation of steps makes sense

smoya commented 3 years ago

you can rerun jobs but not steps afaik, so if you want to have such functionality then in the workflow file you need to have 2 independent jobs

Yeah, totally right. Parallelism only happens at job level, which in this case I think it is not really needed.