fix: specify netlify site ids as plain text + fail when error when deploying

asyncapi / shape-up-process

This repo contains pitches and the current cycle bets. More info about the Shape Up process: https://basecamp.com/shapeup

https://shapeup.asyncapi.io

11 stars 8 forks source link

fix: specify netlify site ids as plain text + fail when error when deploying #110

Closed smoya closed 3 years ago

smoya commented 3 years ago

Description

This moves the netlify site ids from env vars to plain text. It also adds -i and -f args to the curl call, which allow us to see the response headers and to fail the execution in case of a >400 response code respectively.

@derberg would you mind removing the following secrets as they are not used anymore?:

NETLIFY_SHAPEUP_SITE_ID
NETLIFY_ASYNCAPI_SITE_ID

netlify[bot] commented 3 years ago

:construction_worker: Deploy request for asyncapi-shape-up pending review. Visit the deploys page to approve it

:hammer: Explore the source changes: 4a1bd4b1c069e9c9262787a32e7d36bceb847f5f