search

asyncapi / spec-json-schemas

AsyncAPI schema versions
Apache License 2.0
51 stars 54 forks source link

Implement extended tests for bindings and AsyncAPI v3.0.0 definitions #551

Open Pakisan opened 3 months ago

Pakisan commented 3 months ago

Why do we need this improvement?

I have already wrote basic tests for bindings and AsyncAPI v3.0.0 definitions

Now, it's time to tune them up

I expect next:

Initial tests are here: https://github.com/asyncapi/spec-json-schemas/pull/540 Related issue, witch schemas new format: https://github.com/asyncapi/spec-json-schemas/pull/549

How will this change help?

We will be sure that after changes in our schemes nothing will be broken

Screenshots

No response

How could it be implemented/designed?

Tune up basic tests

🚧 Breaking changes

No

👀 Have you checked for similar open issues?

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue?

Yes I am willing to submit a PR!

aeworxet commented 2 months ago

Bounty Issue's service comment

Text labels: bounty/2024-Q3, bounty/advanced, bounty/coding First assignment to third-party contributors: 2024-06-21 00:00:00 UTC+12:00 End Of Life after: 2024-07-31 23:59:59 UTC-12:00

@asyncapi/bounty_team

The Bounty Program is not a Mentorship Program. The accepted level of Bounty Program Participants is Middle/Senior.
Third-party contributors should coherently articulate how they are going to approach the resolution process when expressing a desire to work on this Bounty Issue.
aeworxet commented 2 months ago

Bounty Issue's Timeline

Complexity Level Assignment Date (by GitHub) Start Date (by BP Rules) End Date (by BP Rules) Draft PR Submission Final PR Merge Start Final PR Merge End
Advanced 2024-06-15 2024-07-01 2024-08-25 2024-07-21 2024-08-11 2024-08-25
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.
Keep in mind the responsibility for violations of the Timeline.
aeworxet commented 1 month ago

@Pakisan, please provide the Draft PR.

Pakisan commented 1 month ago

@aeworxet https://github.com/asyncapi/spec-json-schemas/pull/540

Few tests left

Pakisan commented 1 month ago

@aeworxet https://github.com/asyncapi/spec-json-schemas/pull/540

Few tests left

Tagged folks in PR

aeworxet commented 1 month ago

Review for PR https://github.com/asyncapi/spec-json-schemas/pull/540 was requested on 2024-07-26, and it is still in progress.

aeworxet commented 3 weeks ago

@pakisan

Do you need more reviews of PR https://github.com/asyncapi/spec-json-schemas/pull/540 or reviews

https://github.com/asyncapi/spec-json-schemas/pull/540#pullrequestreview-2234501910 https://github.com/asyncapi/spec-json-schemas/pull/540#issuecomment-2289641220

have been enough and you already have an understanding of what to do next?

aeworxet commented 2 weeks ago

Responses, critical for technical resolution of this Bounty Issue (review of the PR) were delayed for three periods of three consecutive working days https://github.com/asyncapi/spec-json-schemas/pull/540#issuecomment-2252385932 https://github.com/asyncapi/spec-json-schemas/pull/540#issuecomment-2289641220

so all remaining target dates of the Bounty Issue's Timeline are extended by four calendar weeks.

Bounty Issue's Timeline Extended

Complexity Level Assignment Date (by GitHub) Start Date (by BP Rules) End Date (by BP Rules) Draft PR Submission Final PR Merge Start Final PR Merge End
Advanced 2024-06-15 2024-07-01 2024-09-22 2024-08-18 2024-09-08 2024-09-22
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.
Keep in mind the responsibility for violations of the Timeline.