asyncapi / spec-json-schemas

AsyncAPI schema versions
Apache License 2.0
51 stars 53 forks source link

feat: extend aws policy configuration #553

Closed Gadam8 closed 1 month ago

Gadam8 commented 2 months ago

Description

The current AWS policy binding configuration doesn't match what is offered by AWS when configuring IAM policies. Condition and Resource are missing and Principal isn't fully fleshed out. This PR addresses this by extending the binding configuration for SNS and SQS.

Related issue(s)

Pakisan commented 2 months ago

@Gadam8 looks good

Don't forget to update information about SNS and SQS here:

VisualBean commented 2 months ago

Maybe make it an enum for one of them 😅. Whatever makes the most sense and is the most ‘true’ to the spec i guess.

Gadam8 commented 1 month ago

@Gadam8 looks good

Don't forget to update information about SNS and SQS here:

I've raised a PR to address this here https://github.com/asyncapi/bindings/pull/256

Pakisan commented 1 month ago

@iancooper @dpwdec up!

dpwdec commented 1 month ago

✅

Pakisan commented 1 month ago

@iancooper hi! One more day, and I'll merge

fyi: @Gadam8 @dpwdec @VisualBean

asyncapi-bot commented 1 month ago

:tada: This PR is included in version 6.8.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: