chore: add tests for dynamic open graph tags

helios2003 commented 1 month ago

Description Added tests for the dynamic open graph tags added in #1122 using jest.

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 032a98073b3515a444e5255a89a2003d0cc36fd3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 1 month ago

Deploy Preview for studio-next failed.

Name	Link
Latest commit	032a98073b3515a444e5255a89a2003d0cc36fd3
Latest deploy log	https://app.netlify.com/sites/studio-next/deploys/66df2fcaef9f190008f434f3

netlify[bot] commented 1 month ago

Deploy Preview for modest-rosalind-098b67 failed.

Name	Link
Latest commit	032a98073b3515a444e5255a89a2003d0cc36fd3
Latest deploy log	https://app.netlify.com/sites/modest-rosalind-098b67/deploys/66df2fca66157000084000fb

netlify[bot] commented 1 month ago

Deploy Preview for asyncapi-studio-design-system ready!

Name	Link
Latest commit	032a98073b3515a444e5255a89a2003d0cc36fd3
Latest deploy log	https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/66df2fcaeee7320008d56e9d
Deploy Preview	https://deploy-preview-1130--asyncapi-studio-design-system.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

helios2003 commented 1 month ago

The tests can be run with pnpm test. It works for my tests but for some reason, it fails the tests written in studio-next/src/services/tests. The stack trace is as follows:

FAIL  src/services/tests/navigation.service.test.ts
  ● Test suite failed to run

    Cannot find module '@/helpers' from 'src/components/common/Dropdown.tsx'                                                                                

    Require stack:                                                                                                                                          
      src/components/common/Dropdown.tsx                                                                                                                    
      src/components/common/index.ts                                                                                                                        
      src/components/Modals/Generator/TemplateParameters.tsx                                                                                                
      src/components/Modals/Generator/GeneratorModal.tsx
      src/components/Modals/index.tsx
      src/services/app.service.ts
      src/services/index.ts
      src/services/tests/navigation.service.test.ts

      1 | import { useState, useRef } from 'react';
      2 |
    > 3 | import { useOutsideClickCallback } from '@/helpers';
        | ^
      4 |
      5 | import type { FunctionComponent, PropsWithChildren, ReactNode } from 'react';
      6 |

      at Resolver._throwModNotFoundError (../../node_modules/.pnpm/jest-resolve@29.7.0/node_modules/jest-resolve/build/resolver.js:427:11)
      at Object.<anonymous> (src/components/common/Dropdown.tsx:3:1)
      at Object.<anonymous> (src/components/common/index.ts:3:1)
      at Object.<anonymous> (src/components/Modals/Generator/TemplateParameters.tsx:4:1)
      at Object.<anonymous> (src/components/Modals/Generator/GeneratorModal.tsx:7:1)
      at Object.<anonymous> (src/components/Modals/index.tsx:1:1)
      at Object.<anonymous> (src/services/app.service.ts:5:1)
      at Object.<anonymous> (src/services/index.ts:5:1)
      at Object.<anonymous> (src/services/tests/navigation.service.test.ts:1:1)

Can someone point me to the right direction of how I should go about resolving the issue?

asyncapi-bot commented 1 month ago

Hello, @helios2003! 👋🏼

    I'm 🧞🧞🧞 Genie 🧞🧞🧞 from the magic lamp. Looks like somebody needs a hand!

    At the moment the following comments are supported in pull requests:

    - `/please-take-a-look` or `/ptal` - This comment will add a comment to the PR asking for attention from the reviewrs who have not reviewed the PR yet.
    - `/ready-to-merge` or `/rtm` - This comment will trigger automerge of PR in case all required checks are green, approvals in place and do-not-merge label is not added
    - `/do-not-merge` or `/dnm` - This comment will block automerging even if all conditions are met and ready-to-merge label is added
    - `/autoupdate` or `/au` - This comment will add `autoupdate` label to the PR and keeps your PR up-to-date to the target branch's future changes. Unless there is a merge conflict or it is a draft PR. (Currently only works for upstream branches.)
    - `/update` or `/u` - This comment will update the PR with the latest changes from the target branch. Unless there is a merge conflict or it is a draft PR. NOTE: this only updates the PR once, so if you need to update again, you need to call the command again.

smoya commented 1 month ago

Why would you open a new PR for adding tests instead of adding those in https://github.com/asyncapi/studio/pull/1122? I would close this and move the tests to the proper PR