feat: merge the studio next and studio apps

catosaurusrex2003 commented 2 months ago

Description

In the first commit, I made necessary changes to the package.json files located both in the root directory and within the studio-next folder. (Please refer to this specific commit to review the changes, as in the subsequent commit I deleted the entire studio folder along with its files.)

After these changes, I thoroughly checked for any regressions or differences between the studio-next app and the currently deployed version of the site. I did not find any discrepancies or issues during this process.

Resolves Issue: #1134

Some questions i have

Should we continue versioning from the last version of studio-next, or should we maintain the versioning from the old studio folder?

This is my first time performing a migration within a monorepo structure, and I would appreciate any guidance or feedback on best practices and to ensure the migration process follows the project's conventions.

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 40d1058774832970d55834c36cf7c1cf1dd5fda2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ---------------- | ----- | | @asyncapi/studio | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 2 months ago

Deploy Preview for modest-rosalind-098b67 ready!

Name	Link
Latest commit	40d1058774832970d55834c36cf7c1cf1dd5fda2
Latest deploy log	https://app.netlify.com/sites/modest-rosalind-098b67/deploys/66f868909a90ad000811ead0
Deploy Preview	https://deploy-preview-1141--modest-rosalind-098b67.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 months ago

Deploy Preview for asyncapi-studio-design-system ready!

Name	Link
Latest commit	40d1058774832970d55834c36cf7c1cf1dd5fda2
Latest deploy log	https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/66f868907f4400000840c63d
Deploy Preview	https://deploy-preview-1141--asyncapi-studio-design-system.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 months ago

Deploy Preview for studio-next failed.

Name	Link
Latest commit	40d1058774832970d55834c36cf7c1cf1dd5fda2
Latest deploy log	https://app.netlify.com/sites/studio-next/deploys/66f868907d1d120008100ad4

Shurtu-gal commented 2 months ago

@catosaurusrex2003 could you resolve the conflicts.

aeworxet commented 2 months ago

https://github.com/asyncapi/studio/pull/1120 was merged just now.

catosaurusrex2003 commented 2 months ago

very beautiful PR 🤩 Resolved conflicts. Now onto migrating content of studio-next into studio

Shurtu-gal commented 2 months ago

very beautiful PR 🤩 Resolved conflicts. Now onto migrating content of studio-next into studio

Great.

Also I guess @fmvilas or @derberg someone among you would have to do some changes on netlify side before we merge this. Basically need to change the runtime to Next.js.

catosaurusrex2003 commented 2 months ago

@Shurtu-gal studio is getting built and deployed correctly but not reachable on the preview link. I think this requires neccesary changes from netlify side.

Shurtu-gal commented 2 months ago

@Shurtu-gal studio is getting built and deployed correctly but not reachable on the preview link. I think this requires neccesary changes from netlify side.

Yeah, I have tagged @fmvilas in a previous comment regarding this.

fmvilas commented 1 month ago

Thanks for the ping, @Shurtu-gal. It's working now 👍

Shurtu-gal commented 1 month ago

Thanks for the ping, @Shurtu-gal. It's working now 👍

Great. Thanks 🥇

Shurtu-gal commented 1 month ago

@catosaurusrex2003 please check the failing tests

catosaurusrex2003 commented 1 month ago

@Shurtu-gal i fixed the ones failing due to linting

The ones failing now are due to a missing studio-next folder.

aeworxet commented 1 month ago

@Shurtu-gal I have a feeling that Sonar issues go beyond the initial scope of this issue and 'good first issue' level. Should they be handled by you (by fixing and pushing to the @catosaurusrex2003's branch)?

Shurtu-gal commented 1 month ago

@Shurtu-gal I have a feeling that Sonar issues go beyond the initial scope of this issue and 'good first issue' level. Should they be handled by you (by fixing and pushing to the @catosaurusrex2003's branch)?

Yeah, I have already talked with him and we are doing that.

Also @fmvilas I think there is some problem with the config as the share feature is working in both mine and @catosaurusrex2003 deploys.

Shurtu-gal commented 1 month ago

I will fix the Sonar Cloud Issues by tomorrow. Just need to correct the netlify config for functions.

Shurtu-gal commented 1 month ago

@Shurtu-gal I have a feeling that Sonar issues go beyond the initial scope of this issue and 'good first issue' level. Should they be handled by you (by fixing and pushing to the @catosaurusrex2003's branch)?

I was going through the sonarcloud issues. Most of them were already present and we don't have a trivial way of solving the tabIndex issue as it would require to replace list with list of buttons.

I have fixed the multiple react problems though and added a change-set. Going ahead with the merge.