[BUG]: No form validation in Subscribe to our newsletter to receive news about AsyncAPI in home Page

love-sonkar commented 1 year ago

Describe the bug

In Home page we have a Subscribe to our newsletter to receive news about AsyncAPI form and there is no validation for email and name.

How to Reproduce

Go to home page scroll down to subscribe to newsletter form and randomly enter any email or name then click on subscribe button.

Screenshots

https://github.com/asyncapi/website/assets/82786865/80a57241-5b17-499e-9280-c24bc576dfdf

Expected behavior

Form must be completely valid like email must be a valid email address. and name must contain 3 or 4 character minimum.

github-actions[bot] commented 1 year ago

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Vikram125609 commented 1 year ago

Can anyone please assign this to me ? We can use RegExp to validate the email and name

Om2123 commented 1 year ago

i think regExp won't work , it can't validate whether domain exits or not . Email validation api's like reacher , truemail would work

derberg commented 1 year ago

yeah regex won't work. but is it a real issue? we are not getting any spam subscriptions. People usually don't do it to open source communities.

also can't be nicely completed until we get https://github.com/asyncapi/website/issues/1091

github-actions[bot] commented 10 months ago

This issue has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

sambhavgupta0705 commented 9 months ago

@derberg @akshatnema should we go ahead with this issue ??

akshatnema commented 8 months ago

Yeah, we can go ahead with this issue.

AKACHI-4 commented 8 months ago

@akshatnema, can I take it and work on it? All I need is to research around the Email validation API to verify the name and email of whoever is entering it.

sambhavgupta0705 commented 8 months ago

yeahhh you may work on this one

sambhavgupta0705 commented 8 months ago

@AKACHI-4 any update

AKACHI-4 commented 8 months ago

Yeah, I looked into various validation APIs, and man, it was kinda time taking. Some of them have pricing issues... However, I tried using Postman to call their API, and everything went smoothly... After all, I decided to go with ZeroBounce because they provide free 100 email validations per month, which is definitely a good choice.

What I'm planning to do now is

Implement email validation directly into the NewsletterSubscribe.js file before fetching from the Netlify function.
Regarding the mentioned issue, I encountered the same thing initially while checking. I guess it's from the function's side.
For now, I commented out that part so I can focus on implementing validation only. But I'll definitely look into it.

Here's the image I was using :- I tried usebouncer for checking, but I'm getting some CORS errors though. I'll resolve them and try to push the changes as soon as possible.

sambhavgupta0705 commented 8 months ago

Ohkkk great!!

sambhavgupta0705 commented 8 months ago

Raise a PR when you are done with the work

AKACHI-4 commented 8 months ago

Hey @sambhavgupta0705 .. I am done with the changes. kindly review it and guide for further in steps.

github-actions[bot] commented 4 months ago

This issue has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

JeelRajodiya commented 2 months ago

@sambhavgupta0705 Is this issue still relevant? I would like to work on it.

sambhavgupta0705 commented 2 months ago

@sambhavgupta0705 Is this issue still relevant? I would like to work on it.

yes you may

Pruthvik-P commented 2 months ago

can i work on it?

JeelRajodiya commented 2 months ago

can i work on it?

I am currently not working on the issue, because of my exams. If you want you can start working on it :)

TejasSaraf commented 1 month ago

Hey @sambhavgupta0705, I want to work on this issue an you please assign it to me?

ParagGhatage commented 2 hours ago

Hi @love-sonkar , I just checked the AsyncAPI website, and it seems this issue is still present. I’d love to work on it if it's available. Let me know!

asyncapi / website