asyncapi / website

AsyncAPI specification website
https://www.asyncapi.com
Apache License 2.0
526 stars 668 forks source link

[BUG] layout of tree in specification explorer doesnt reorganize on collapsing #3334

Open catosaurusrex2003 opened 1 month ago

catosaurusrex2003 commented 1 month ago

Describe the bug.

see the blank space between components and operations

whenever you expand and collapse a node in the tree the blank space is retained by the node even though it is not expanded.

image

Expected behavior

when i collapse a node A and then expand another node B

node A should not have extra blank space as its children are hidden

Screenshots

added

How to Reproduce

  1. go to https://www.asyncapi.com/docs/reference/specification/v3.0.0-explorer
  2. expand components
  3. collapse components
  4. expand channels
  5. see the blank space

🥦 Browser

Mozilla Firefox

👀 Have you checked for similar open issues?

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

Yes I am willing to submit a PR!

github-actions[bot] commented 1 month ago

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

hkv24 commented 1 month ago

@catosaurusrex2003 could you please provide few files which might have the logic of rendering this tree

catosaurusrex2003 commented 1 month ago

@hkv24 I'm not quite sure what you mean by 'files.' Could you clarify that for me?

I was just exploring the asyncapi spec https://www.asyncapi.com/docs/reference/specification/v3.0.0-explorer when i encountered this

hkv24 commented 1 month ago

@catosaurusrex2003 I meant the file from the codebase. Anyway did you figured out something to solve this one?

catosaurusrex2003 commented 1 month ago

I haven't started working on this issue yet and was hoping to see if others encounter it first to confirm it's a legitimate concern. But if you’d like to solve it, feel free to go ahead!

visheshkrishna commented 4 weeks ago

@catosaurusrex2003 I see that the issue still persists, can you mention the name of the file where the actually logic of this issue lies ?

JeelRajodiya commented 4 weeks ago

Hello everyone, for those of you who were asking for the files which are responsible for the issue.

Here is the file, I don't know if the issue can be resolved by just editing that file since we are using schyma library to render the tree, so you should consider opening an issue and PR on that repository to resolve the issue.

catosaurusrex2003 commented 4 weeks ago

@JeelRajodiya thanks 👌 I was just about to comment on that too 😆

I will be opening a PR in https://github.com/AceTheCreator/schyma soon