Closed anmolyadav-dev closed 2 weeks ago
The pull request introduces a new CSS rule in styles/globals.css
, specifically adding a cursor: pointer;
style to the select
element. This change aims to enhance the user interface by providing a visual indication that the select
element is interactive, aligning with user expectations for interactive elements.
File | Change Summary |
---|---|
styles/globals.css | Added cursor: pointer; to select element. |
Objective | Addressed | Explanation |
---|---|---|
Add Pointer Cursor on Hover over Selector (#3345) | ✅ |
cursor: pointer;
rule for the select
element in the main PR.ready-to-merge
, bounty
🐰 In the meadow, hopping near,
A pointer cursor brings us cheer!
Select with ease, don't hesitate,
Interactive joy, oh, it's so great!
With every click, the fun will grow,
A simple change, but now you know! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Built without sensitive environment variables
Name | Link |
---|---|
Latest commit | a09f528bf2e6af678b1e1035951d26654ff723d7 |
Latest deploy log | https://app.netlify.com/sites/asyncapi-website/deploys/672d078312e4b60008f32b56 |
Deploy Preview | https://deploy-preview-3346--asyncapi-website.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 59.01%. Comparing base (
8ec5340
) to head (a09f528
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
⚡️ Lighthouse report for the changes in this PR: | Category | Score |
---|---|---|
🔴 Performance | 44 | |
🟢 Accessibility | 98 | |
🟢 Best practices | 92 | |
🟢 SEO | 100 | |
🔴 PWA | 33 |
Lighthouse ran on https://deploy-preview-3346--asyncapi-website.netlify.app/
You can try to Fix the PR title and raise a PR again to get through the lintPR title
@anmolyadav-dev That's a nice addition. Can you please search other dropdown elements in the website/codebase that do not have such a cursor pointer on hover, and add those changes as well to this PR.
Example: one such dropdown is on page https://www.asyncapi.com/tools/generator
@anshgoyalevil Sure i will search and fix more of these . thankyou for the feedback.
@anshgoyalevil i changed the global style for select element so every select element should now have a cursor pointer
@anmolyadav-dev Notice that hovering on the dropdown options does not change the cursor. Can we fix that also?
@anshgoyalevil i searched for that but it is default by operating system and cannot be overwritten easily https://stackoverflow.com/questions/22770603/change-cursor-over-option-tags
/rtm
@anshgoyalevil and i also have a question . whenever i do npm run dev 3 files get automatically changed i think color.mdx and 3 other is it fine
@anshgoyalevil and i also have a question . whenever i do npm run dev 3 files get automatically changed i think color.mdx and 3 other is it fine
That shouldn't happen. What are the changes introduced in those files?
@anshgoyalevil no visible changes. it just shows file changed and add it in status
Description added cursor pointer over language selector
Related issue(s)
Fixes #3345
Summary by CodeRabbit
select
element to indicate interactivity, enhancing the user experience.