asyncapi / website

AsyncAPI specification website
https://www.asyncapi.com
Apache License 2.0
527 stars 665 forks source link

feat: add cursor pointer on selector element #3346

Closed anmolyadav-dev closed 2 weeks ago

anmolyadav-dev commented 3 weeks ago

Description added cursor pointer over language selector

Related issue(s)

Fixes #3345

Summary by CodeRabbit

coderabbitai[bot] commented 3 weeks ago

Walkthrough

The pull request introduces a new CSS rule in styles/globals.css, specifically adding a cursor: pointer; style to the select element. This change aims to enhance the user interface by providing a visual indication that the select element is interactive, aligning with user expectations for interactive elements.

Changes

File Change Summary
styles/globals.css Added cursor: pointer; to select element.

Assessment against linked issues

Objective Addressed Explanation
Add Pointer Cursor on Hover over Selector (#3345)

Possibly related PRs

Suggested labels

ready-to-merge, bounty

Suggested reviewers

🐰 In the meadow, hopping near,
A pointer cursor brings us cheer!
Select with ease, don't hesitate,
Interactive joy, oh, it's so great!
With every click, the fun will grow,
A simple change, but now you know! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
netlify[bot] commented 3 weeks ago

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
Latest commit a09f528bf2e6af678b1e1035951d26654ff723d7
Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/672d078312e4b60008f32b56
Deploy Preview https://deploy-preview-3346--asyncapi-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.01%. Comparing base (8ec5340) to head (a09f528). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3346 +/- ## ======================================= Coverage 59.01% 59.01% ======================================= Files 21 21 Lines 649 649 ======================================= Hits 383 383 Misses 266 266 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

asyncapi-bot commented 3 weeks ago
⚡️ Lighthouse report for the changes in this PR: Category Score
🔴 Performance 44
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-3346--asyncapi-website.netlify.app/

lakshaydewan commented 2 weeks ago

You can try to Fix the PR title and raise a PR again to get through the lintPR title

anshgoyalevil commented 2 weeks ago

@anmolyadav-dev That's a nice addition. Can you please search other dropdown elements in the website/codebase that do not have such a cursor pointer on hover, and add those changes as well to this PR.

Example: one such dropdown is on page https://www.asyncapi.com/tools/generator

anmolyadav-dev commented 2 weeks ago

@anshgoyalevil Sure i will search and fix more of these . thankyou for the feedback.

anmolyadav-dev commented 2 weeks ago

@anshgoyalevil i changed the global style for select element so every select element should now have a cursor pointer

anshgoyalevil commented 2 weeks ago

@anmolyadav-dev Notice that hovering on the dropdown options does not change the cursor. Can we fix that also?

anmolyadav-dev commented 2 weeks ago

@anshgoyalevil i searched for that but it is default by operating system and cannot be overwritten easily https://stackoverflow.com/questions/22770603/change-cursor-over-option-tags

anshgoyalevil commented 2 weeks ago

/rtm

anmolyadav-dev commented 2 weeks ago

@anshgoyalevil and i also have a question . whenever i do npm run dev 3 files get automatically changed i think color.mdx and 3 other is it fine Screenshot 2024-11-08 000631

anshgoyalevil commented 2 weeks ago

@anshgoyalevil and i also have a question . whenever i do npm run dev 3 files get automatically changed i think color.mdx and 3 other is it fine Screenshot 2024-11-08 000631

That shouldn't happen. What are the changes introduced in those files?

anmolyadav-dev commented 2 weeks ago

@anshgoyalevil no visible changes. it just shows file changed and add it in status

Screenshot 2024-11-08 001803